Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix image.WorkingDir not saving #4

Merged
merged 1 commit into from Feb 21, 2019
Merged

fix: fix image.WorkingDir not saving #4

merged 1 commit into from Feb 21, 2019

Conversation

soldair
Copy link
Collaborator

@soldair soldair commented Feb 21, 2019

No description provided.

DominicKramer
DominicKramer approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it is good that the options.WorkingDirectory overrides this.WorkingDirectory.

@soldair soldair merged commit 61397cb into master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicKramer DominicKramer DominicKramer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soldair @DominicKramer