Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support adding in memory files to layers #15

Merged
merged 4 commits into from Apr 16, 2019

Conversation

soldair
Copy link
Collaborator

@soldair soldair commented Mar 26, 2019

BREAKING CHANGE: image.addFiles obj keys and values flipped

image.addFiles(obj)
when paths are specified as an object the keys are now targetDirectory.
this enables copying the same files into a container to different paths and CustomFiles

image.addFiles(obj)
when paths are specified as an object the keys are now `targetDirectory`.
this enables copying the same files into a container to different paths and CustomFiles
@ofrobots
Copy link
Contributor

If you're following conventional commits style, the 'BREAKING CHANGE:' is supposed to be part of the body of the commit message.

@soldair
Copy link
Collaborator Author

soldair commented Mar 26, 2019

ill get it in the squash ;)

@soldair soldair changed the title BREAKING CHANGE: image.addFiles obj keys and values flipped feat: support adding in memory files to layers Mar 27, 2019
Copy link
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple comments.

README.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@soldair soldair merged commit 9b716ee into master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants