Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to sql NullTypes #122

Open
apFlex opened this issue Nov 17, 2017 · 3 comments
Open

Add support to sql NullTypes #122

apFlex opened this issue Nov 17, 2017 · 3 comments

Comments

@apFlex
Copy link

apFlex commented Nov 17, 2017

It would be great adding support to handle NullTypes from package "database/sql".

At the moment it throws an error during UnmarshalPayload method. It finds fields type mismatch and throw this error: The struct field was not of a known number type.

@quetzyg
Copy link
Contributor

quetzyg commented Feb 19, 2021

Hi @aren55555, @shwoodard,

I'm aware this package has been flagged with no maintenance intended (on your part, at least), but I wonder if you're still accepting pull requests (given there's a bunch of them waiting to be merged)?

This ticket has been open for ages with no resolution in sight and I would also like for sql.NullXXX types to be supported. I could work on this in the next few days if you're open to it.

@aren55555
Copy link
Contributor

@quetzyg I wasn't personally going to develop this feature (as you had pointed out) - but if you submit a well-tested PR I'd be happy to review it!

@quetzyg
Copy link
Contributor

quetzyg commented Mar 3, 2021

Thanks for the feedback @aren55555.

I've got most of the needed changes done, but the code is still a bit rough, so I'll have to work on it a bit more before I submit a PR. Meanwhile, my workaround for this issue is to use an intermediary struct (i.e. a DTO approach).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants