feat: added skipping of package.json check if package is whitelisted (resolves #118) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
suggested changes
May 18, 2020
|
@JustinBeckwith Thank you for the suggestions, I've resolved the issues and added a test. Also, I've moved the function away from reliance on JS |
|
@JustinBeckwith Apologies for the repeated mention, is there anything else required for this PR? |
JustinBeckwith
approved these changes
May 25, 2020
|
Thanks for sticking with me on the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm setting default values for name and version, just to not cause issues further down the road.
Resolves #118.