Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added support for the UNLICENSED NPM magic value (fixes #113) #134

Merged
merged 2 commits into from
May 18, 2020

Conversation

mat-sz
Copy link
Contributor

@mat-sz mat-sz commented May 18, 2020

As far as I'm aware only all caps spelling (with alternative UNLICENCED spelling) is allowed (see: validate-npm-package-license.js).

This resolves that issue, the library correctly treats UNLICENSED as non-green (all copyright retained). I've added a test case for that as well.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mat-sz
Copy link
Contributor Author

mat-sz commented May 18, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@JustinBeckwith JustinBeckwith changed the title Added support for the UNLICENSED NPM magic value (fixes #113) fix: Added support for the UNLICENSED NPM magic value (fixes #113) May 18, 2020
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thank you!

@JustinBeckwith JustinBeckwith merged commit c7966eb into google:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants