Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom VJP bwd shape/type checking optional. #20827

Open
davidhchoi opened this issue Apr 19, 2024 · 0 comments
Open

Make custom VJP bwd shape/type checking optional. #20827

davidhchoi opened this issue Apr 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@davidhchoi
Copy link

davidhchoi commented Apr 19, 2024

Would it be possible to make this check introduced here optional? We were previously putting things with deliberately different shapes into this for logging, as an easy way of extracting info through the gradients. Though based on the linked PR, it seems definitely useful in general.

It seems like removing the check doesn't currently break anything.

@davidhchoi davidhchoi added the enhancement New feature or request label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant