Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] No systrap on the diagram in the Platform Guide page #10386

Closed
dimakuv opened this issue May 6, 2024 · 0 comments · Fixed by #10432
Closed

[Docs] No systrap on the diagram in the Platform Guide page #10386

dimakuv opened this issue May 6, 2024 · 0 comments · Fixed by #10432
Assignees
@EtiennePerot
Labels
type: bug Something isn't working

Comments

@dimakuv
Copy link

dimakuv commented May 6, 2024 •
edited

Description

The diagram in the Platform Guide page is old: https://gvisor.dev/docs/architecture_guide/platforms/#implementations

It doesn't have the systrap platform. Instead, it only distinguishes between the KVM and the deprecated ptrace platforms.

The diagram must be updated to reflect the current state and the text description (which is up to date).

UPDATE: You may also want to add a note to the blog post https://gvisor.dev/blog/2020/10/22/platform-portability/, that ptrace platform is deprecated in favor of systrap.
@dimakuv dimakuv added the type: bug Something isn't working label May 6, 2024
@EtiennePerot EtiennePerot self-assigned this May 6, 2024
copybara-service bot pushed a commit that referenced this issue May 11, 2024
@EtiennePerot @gvisor-bot
Update platform diagram to replace ptrace with systrap.
4b80904 
Also include reference to Systrap in the Platform Portability blog post.

Fixes #10386

PiperOrigin-RevId: 632639005
@copybara-service copybara-service bot mentioned this issue May 11, 2024
Merged
copybara-service bot pushed a commit that referenced this issue May 14, 2024
@EtiennePerot @gvisor-bot
Update platform diagram to replace ptrace with systrap.
8f2b09c 
Also include reference to Systrap in the Platform Portability blog post.

Fixes #10386

PiperOrigin-RevId: 632639005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EtiennePerot EtiennePerot

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update platform diagram to replace ptrace with systrap. google/gvisor
2 participants
@EtiennePerot @dimakuv