-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrency issue when new mounts are added #411
Comments
Another approach to fixing this would just be to compare the Happy to review any PR! |
Great point @josephlr! |
Fixed by 068b9f8 |
There was a release recently, and there haven't been many changes since then, so it probably will be at least a few months before we do another release. |
In the filesystem/mountpoint.go file the mountsByDevice map is recreated on each call of update UpdateMountInfo.
This causes problem, if these steps occurs!
This will result in the fact that the policy.context.Mount will have the old memory address from the old mountsByDevice map while the filesystems.findMount will find the new object and then in the comparison the following error will be thrown in the policy.apply function.
(%!w(*actions.ErrDifferentFilesystem=&{0xc00157b130 0xc00208a140}).
This currently affects the ceph-csi project and more information can be found in this issue:
ceph/ceph-csi#4592
I have tested a solution were only the new mount objects are updated and that would at least work for my specific use-case, I will open a PR for this and look forward to any feedback
The text was updated successfully, but these errors were encountered: