Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Crimson Text to latest release + add Crimson #284

Closed
KyleAMathews opened this issue Jun 27, 2016 · 9 comments
Closed

Update Crimson Text to latest release + add Crimson #284

KyleAMathews opened this issue Jun 27, 2016 · 9 comments
Assignees

Comments

@KyleAMathews
Copy link

https://github.com/skosch/Crimson

@davelab6 davelab6 self-assigned this Jun 27, 2016
@davelab6
Copy link
Member

Thanks Kyle!

@davelab6 davelab6 modified the milestone: Update Families Jul 8, 2016
@davelab6
Copy link
Member

There are lots of issues in https://github.com/skosch/Crimson/issues so finding a good release candidate will be important :)

@thlinard
Copy link
Contributor

"While you are looking at the new, improved version, Google Fonts continues to offer the clumsy-looking original via and has not heeded the repeated pleas for an upgrade. If you want to stick with Google Fonts, I recommend you switch to Amiri in the meantime – it uses the new Crimson for its Roman characters."

@davelab6
Copy link
Member

@thlinard yes, I know... ;p

@khaledhosny
Copy link
Contributor

My version in Amiri is not identical to upstream either, it has many fixes that I committed upstream years ago but got accidentally overwritten after that and the fonts diverged since then.

@skosch
Copy link

skosch commented Jul 26, 2017

@khaledhosny I do remember you had sorted out most of the OpenType stuff, and probably other things, and then other people's (equally important but evidently corrupted) PRs wiped out much of that effort. With too much on my plate I kind of threw in the towel after that, and I never did apologize for wasting your contributions like that 🙇‍♂️ (and then over time more and more issues piled up ...)

I'm glad I saw your comment though, because your work on Amiri may be valuable to @m4rc1e and @Fonthausen (in case you missed it, they're improving Crimson for the very purpose of this here issue). I just wanted to point out the potential for re-use of Khaled's fixes and maybe an eventual re-merge.

@arthurattwell
Copy link

As a regular user of both Crimson Text and Crimson, I'd love to see both versions of the font available on Google Fonts as separate fonts, because they are so very different. We often choose between them for web projects. If Crimson Text were to be updated with the latest Crimson, this would have a significant impact on the design of sites that use it – a breaking change to a designer's eye.

@davelab6 davelab6 changed the title Update Crimson Text to latest release Update Crimson Text to latest release + add Crimson Nov 3, 2017
@davelab6
Copy link
Member

davelab6 commented Nov 3, 2017

Thanks for that context, I've updated the issue title to reflect that

@RosaWagner RosaWagner removed this from the Family Updates milestone Aug 13, 2021
@emmamarichal
Copy link
Collaborator

emmamarichal commented May 27, 2022

Fixed #4416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants