Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf 4.21 support #45

Open
gitpushdashf opened this issue Jun 2, 2022 · 1 comment
Open

protobuf 4.21 support #45

gitpushdashf opened this issue Jun 2, 2022 · 1 comment

Comments

@gitpushdashf
Copy link

Currently, we are locked into 3.x with ~=3.13.

If I forcibly install 4.21, I get this:

E   TypeError: Descriptors cannot not be created directly.
E   If this call came from a _pb2.py file, your generated code is out of date and must b
e regenerated with protoc >= 3.19.0.
E   If you cannot immediately regenerate your protos, some other possible workarounds ar
e:
E    1. Downgrade the protobuf package to 3.20.x or lower.
E    2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python
 parsing and will be much slower).
E
E   More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-0
6#python-updates

Would it be possible to regenerate with a newer protoc and allow for protobuf v4 to be used?

Thank you!

@nickgeorge
Copy link
Collaborator

Working on this. Turns out to be a bit annoying because there's a conflict with a json name on a Reference field... but should be able to get a solution out in a week or two.

copybara-service bot pushed a commit that referenced this issue Nov 9, 2023
…is is step 1 of resolving #45.

PiperOrigin-RevId: 576140989
copybara-service bot pushed a commit that referenced this issue Nov 10, 2023
…is is step 1 of resolving #45.

PiperOrigin-RevId: 576140989
copybara-service bot pushed a commit that referenced this issue Nov 13, 2023
…is is step 1 of resolving #45.

PiperOrigin-RevId: 576140989
copybara-service bot pushed a commit that referenced this issue Nov 14, 2023
…is is step 1 of resolving #45.

PiperOrigin-RevId: 582013548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants