Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace/Class collisions with C# compiler in DatatypesReflection #26

Open
saltatory opened this issue Nov 6, 2020 · 2 comments
Open

Comments

@saltatory
Copy link

saltatory commented Nov 6, 2020

Both proto/google/fhir/proto/r4/core/datatypes.proto and proto/google/fhir/proto/r4/core/profiles/datatypes.proto generate a class named DatatypesReflection as part of the standard output from protoc. Both *.proto files use the same package google.fhir.r4.core. This results in a duplicate name collision in the generated output.

This problem disappears if the datatypes.proto file is moved into the google.fhir.r4.core.profiles namespace.

Tho' I am not certain if that causes any other unrelated issues.

@Cam2337
Copy link
Collaborator

Cam2337 commented Nov 26, 2020

We'd love to suport C# but don't really have the bandwidth right now :(

If going this route, as a first step you might try to have a look at https://github.com/bazelbuild/rules_dotnet to see if you can get support going with Bazel?

@saltatory
Copy link
Author

Thanks for the reply Cam!

Got it ... I'll take a look at the Bazel configuration. It may be a while as I'm working on other elements of the project. If I come up with something, I'll contribute back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants