Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllowDomainlist CORS in ga.js depends on deployment platform #147

Open
indcoder opened this issue Aug 21, 2022 · 2 comments
Open

AllowDomainlist CORS in ga.js depends on deployment platform #147

indcoder opened this issue Aug 21, 2022 · 2 comments

Comments

@indcoder
Copy link
Contributor

cc @cramforce ,

My issue is very specific to Netlify deployment..

In the ga.js file, the example domain has a trailing slash

image

But unfortunately the origin returned by Netlify is bereft of the trailing slash [I'm not sure of vercel etc]

image

leading to

image

Perhaps in the README and as comments in ga.js we need to draw users attention to it....its a simple but tricky bug; it takes some time to debug...or the equality comparison needs to disregard the trailing slash.

Or the example [industrail empathy needs to be shown without the trailing slash]

@cramforce
Copy link
Collaborator

Yeah, the / is wrong. Do you want to send a PR to fix it?

@indcoder
Copy link
Contributor Author

indcoder commented Aug 21, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants