Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up HVAC/VLV Types #654

Open
tasodorff opened this issue Jun 16, 2022 · 0 comments
Open

Clean Up HVAC/VLV Types #654

tasodorff opened this issue Jun 16, 2022 · 0 comments
Assignees
@cstirdivant
Labels
ontology model Extensions or edits to the ontology model

Comments

@tasodorff
Copy link
Collaborator

Some of what is implemented in HVAC/VLV.yaml is counter to our general guidance for how to model with the least set of necessary fields: some implement CDWPVM, HWPVM, etc.; this might not be favorable, as valve and other context is included in the fields.

This is different from PMP, where we do not call out things like pump_run_command. Consider changing it.
@mschulze17 mschulze17 added the ontology model Extensions or edits to the ontology model label Apr 21, 2023
@cstirdivant cstirdivant self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cstirdivant cstirdivant

Labels
ontology model Extensions or edits to the ontology model
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tasodorff @cstirdivant @mschulze17