[HVAC] Remove Unused Non-Canonicals #1333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shambergoldstein
commented
May 2, 2024
| @@ -23,13 +23,6 @@ RP_CAM_DPHCC_ZTC: | |||
| - DPHCC | |||
| - ZTC | |||
|
|
|||
| RSR_HHCDM: | |||
There was a problem hiding this comment.
moved to rsr but not used by anything. should it just be deleted instead?
shambergoldstein
commented
May 2, 2024
| @@ -12,6 +12,13 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| RSR_HHCDM: | |||
There was a problem hiding this comment.
nothing in this file, nor hwrsr or chwrsr, is used by anything. should they be removed?
cstirdivant
requested changes
May 3, 2024
| @@ -1662,34 +1592,6 @@ FCU_DFSS_DFVSC_ZTC_CHWZTC_HWZTC_NONCANONICAL_2: | |||
| - run_mode | |||
| - exercise_mode | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please keep this type - it will be used
| @@ -4515,66 +4515,6 @@ AHU_SFSS2X_SFVSC2X_RFSS2X_RFVSC2X_HWSC_CHWSC_SSPC_MOAFC_ECON_EDPM_RD_UV: | |||
| # TODO: Every AHU must have outside_air_temperature_sensor, so almost every AHU is currently incomplete. | |||
| # See b/148117417 for details | |||
|
|
|||
| AHU_UNDEFINED: | |||
There was a problem hiding this comment.
Potentially retain this type @tasodorff what was this created for?
| @@ -44,24 +44,3 @@ CRREF_SS_CREFM: | |||
| - CRREF | |||
| - SS | |||
| - CREFM | |||
|
|
|||
| CRREF_SS_CREFM_NONCANONICAL_1: | |||
There was a problem hiding this comment.
Retain these - just created by Jane recently
| @@ -412,12 +412,6 @@ VAV_ED_RMM: | |||
| - ED | |||
| - RMM | |||
|
|
|||
| VAV_UNDEFINED: | |||
There was a problem hiding this comment.
Potentially retain @tasodorff please inform if this needs to be retained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up non canonical types in the hvac namespace (excluding fans) that are not used in the real world