Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto GUID enhancements #1260

Open
cstirdivant opened this issue Jan 29, 2024 · 0 comments
Open

Auto GUID enhancements #1260

cstirdivant opened this issue Jan 29, 2024 · 0 comments

Comments

@cstirdivant
Copy link
Collaborator

          > You must enable auto GUID generation for your PRs by following the instructions here https://github.com/google/digitalbuildings/blob/master/CONTRIBUTING.md#enabling-auto-guid-generation-for-prs

Auto-generation does not work for your first PR (you submitted your first PR last week) -- if the GUIDs aren't automatically added, please add manually by generating an UUID4 (https://www.uuidgenerator.net/) and inserting into your branch.

Looks like the GUIDs are only generated on pushes to a branch called master. Is there a reason that the logic doesn't allow GUID generation on pull-requests to your master branch? I don't mind producing another PR to expand this to improve outside engagement, but I'm weary of stepping on toes (or there could be a darn good reason not to that I'm unfamiliar with).

Originally posted by @ohshazbot in #1254 (comment)

Good questions -- we will need to dig into the original technical design documents before proceeding. Opening as issue to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant