Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DF2XSS #1228

Open
cstirdivant opened this issue Dec 15, 2023 · 1 comment · May be fixed by #1274
Open

Remove DF2XSS #1228

cstirdivant opened this issue Dec 15, 2023 · 1 comment · May be fixed by #1274
Assignees
Labels
ontology model Extensions or edits to the ontology model

Comments

@cstirdivant
Copy link
Collaborator

cstirdivant commented Dec 15, 2023

DF2XSS is a duplicate of DFSS2X

  • remove DF2XSS as it does not match naming precedent
  • update all canonicals that implement DF2XSS to use DFSS2X instead
@cstirdivant
Copy link
Collaborator Author

Ramifications of this change:

Affects the following canonical and non-canonical types:

  • FCU_DF2XSS_DSP_DXZC (implemented by four entities)
  • FCU_DF2XSS_DSP_DXZC_NONCANONICAL_1 (implemented by zero entities)
  • FCU_DF2XSS_RTC_DXRC (implemented by zero entities)
  • FCU_DF2XSS_RTC_DXRC_NONCANONICAL_1 (implemented by zero entities)
  • FCU_DF2XSS_RTC_DXRC_NONCANONICAL_2 (implemented by zero entities)
  • MAU_DF2XSS_DFVSC2X_DSP_HTZC (implemented by zero entities)
  • MAU_DF2XSS_DFVSC2X_HP2ZC_HTZC_OAFC (implemented by zero entities)

Suggested next steps:

  • Delete DF2XSS from the abstracts
  • For all canonical types affected, replace DF2XSS with DFSS2X
  • For all non-canonical types, remove them entirely (since they are not implemented by any entities, and are non-canonical)
  • For FCU_DF2XSS_DSP_DXZC, evaluate the lift to re-map the necessary fan fields to align with DFSS2X

@cstirdivant cstirdivant self-assigned this Feb 16, 2024
@cstirdivant cstirdivant linked a pull request Feb 16, 2024 that will close this issue
@cstirdivant cstirdivant added the ontology model Extensions or edits to the ontology model label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ontology model Extensions or edits to the ontology model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant