Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the clinical reasoning version to v3.1.0 #2467

Open
dubdabasoduba opened this issue Mar 8, 2024 · 8 comments · May be fixed by #2527
Open

Update the clinical reasoning version to v3.1.0 #2467

dubdabasoduba opened this issue Mar 8, 2024 · 8 comments · May be fixed by #2527
Assignees
Labels
effort:small Small effort - 2 days P2 Medium priority issue type:enhancement New feature or request

Comments

@dubdabasoduba
Copy link
Collaborator

dubdabasoduba commented Mar 8, 2024

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

  • We need to update this version to allow the testing of this fix on the SDK-implementing apps

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@santosh-pingle
Copy link
Collaborator

@jingtang10 @aditya-07

@jingtang10
Copy link
Collaborator

looks good @dubdabasoduba do you have time to do this?

@pld
Copy link
Collaborator

pld commented Mar 13, 2024

No we don't have capacity to work on this

@MJ1998 MJ1998 added type:enhancement New feature or request P2 Medium priority issue effort:small Small effort - 2 days labels Mar 14, 2024
@owais-vd
Copy link
Collaborator

Hi, I updated the clinical-reasoning version from 3.0.0-PRE9-SNAPSHOT to the latest 3.2.0 locally but after upgradation, got the following errors on some files.

cc: @jingtang10 @dubdabasoduba @pld @MJ1998 @santosh-pingle

@dubdabasoduba
Copy link
Collaborator Author

Hi, I updated the clinical-reasoning version from 3.0.0-PRE9-SNAPSHOT to the latest 3.2.0 locally but after upgradation, got the following errors on some files.

cc: @jingtang10 @dubdabasoduba @pld @MJ1998 @santosh-pingle

@vitorpamplona is this something you can support on?

@jingtang10 jingtang10 self-assigned this Mar 27, 2024
@MJ1998
Copy link
Collaborator

MJ1998 commented Apr 7, 2024

Comment from Vitor:-

Just make sure all dependencies align. You might need to update HAPI's base version to whichever version the clinical reasoning uses.

@MJ1998
Copy link
Collaborator

MJ1998 commented Apr 9, 2024

Updating PlanDefinitionProcessor and evaluateMeasure is easy.

To update apply APIs I think it will require adding knowledge manager(KM) as a dependency in workflow. Then we will have repository implementations from KM.

For IgLayoutMode and ResourceCategory this is the relevant PR in the CQF library repo where these were removed. Can you figure out how to transition. They mention something like flat structure.

applyR5 will be updated similarly like the other apply methods in FhirOperator, right ?

@dubdabasoduba
@aditya-07

@MJ1998
Copy link
Collaborator

MJ1998 commented Apr 15, 2024

My bad, I got confused between this and another issue in KM. We don't need to add KM as a dependency.

This is how you can resolve the apply funciton:-

return planDefinitionProcessor.apply(
      /* planDefinition = */ Eithers.forMiddle3 (IdType("PlanDefinition", planDefinitionId)),
      /* subject = */ subject,
      /* encounter = */ encounterId,
      /* practitioner = */ null,
      /* organization = */ null,
      /* userType = */ null,
      /* userLanguage = */ null,
      /* userTaskContext = */ null,
      /* setting = */ null,
      /* settingContext = */ null,
      /* parameters = */ null,
      /* useServerData = */ null,
      /* bundle = */ null,
      /* prefetchData = */ null,
      libraryProcessor,
    ) as IBaseResource

@dubdabasoduba
Copy link
Collaborator Author

My bad, I got confused between this and another issue in KM. We don't need to add KM as a dependency.

This is how you can resolve the apply funciton:-

return planDefinitionProcessor.apply(
      /* planDefinition = */ Eithers.forMiddle3 (IdType("PlanDefinition", planDefinitionId)),
      /* subject = */ subject,
      /* encounter = */ encounterId,
      /* practitioner = */ null,
      /* organization = */ null,
      /* userType = */ null,
      /* userLanguage = */ null,
      /* userTaskContext = */ null,
      /* setting = */ null,
      /* settingContext = */ null,
      /* parameters = */ null,
      /* useServerData = */ null,
      /* bundle = */ null,
      /* prefetchData = */ null,
      libraryProcessor,
    ) as IBaseResource

This makes sense. Looking forward to testing the PR

@fredhersch fredhersch assigned MJ1998 and unassigned jingtang10 Apr 18, 2024
@MJ1998 MJ1998 linked a pull request Apr 24, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:small Small effort - 2 days P2 Medium priority issue type:enhancement New feature or request
Projects
Status: New
Development

Successfully merging a pull request may close this issue.

6 participants