Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve initial load of calculated expression #2522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve initial load of calculated expression #2522

wants to merge 2 commits into from

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2519

Description
On initial load of forms:

  1. Iterate all items with calculated expression
  2. Evaluate the calculated expression
  3. Update the QR item answer

Alternative(s) considered
N/A

Type
Improvement

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@FikriMilano FikriMilano requested review from santosh-pingle and a team as code owners April 23, 2024 02:32
MJ1998
MJ1998 requested changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there is an item (maybe display item) which is dependent on the initial calculated expression ?

datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
qItem,
questionnaireResponse.allItems.find { qrItem -> qrItem.linkId == qItem.linkId },
questionnaireResponse.allItems.find { qrItem -> qrItem.linkId == qItem.linkId } ?: QuestionnaireResponseItemComponent(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason of adding ?: QuestionnaireResponseItemComponent() ?

datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
questionnaireResponseItem,
)
if (itemToAnswersPair.second.isEmpty()) return
if (modifiedQuestionnaireResponseItemSet.contains(questionnaireResponseItem)) return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check this in the beginning of the function ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MJ1998 MJ1998 MJ1998 requested changes

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle santosh-pingle is a code owner

@shelaghm shelaghm Awaiting requested review from shelaghm shelaghm was automatically assigned from google/android-fhir

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Status: PR under Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve initial load for calculated-expression
2 participants
@FikriMilano @MJ1998