Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable drop down answer option. #2526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdityaKBhadragond14
Copy link

@AdityaKBhadragond14 AdityaKBhadragond14 commented Apr 23, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2505

Description
In the DropDownViewHolderFactory the hyphen("-") is being set as the default answer option to the drop down. Instead of setting it a fixed answer I have made it configurable. To change the default answer option the questionnaire item representing the drop down item will have the initial property which will have a valueString. The default answer option will be filled with the initial property value if available else it will be filled hyphen("-").
This approach ensures that the configuration will be done via questionnaire itself and the code need be changed everytime to change a default answer option.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Bug Fix.

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect as per rules in Questionnaire:-
+ Rule: If one or more answerOption is present, initial cannot be present. Use answerOption.initialSelected instead

However we don't even need this. You can override the hyphen string constant in your application and the dropdown will read that value instead of "-" defined in the sdc library.

What you may do is change the name of the string constant from hyphen to maybe default_drop_down_value ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR under Review
Development

Successfully merging this pull request may close these issues.

Configurable hyphen("-") answer option in dropdown menu.
2 participants