Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FhirEngine instance creation should be decoupled from Database instance #2457

Open
MJ1998 opened this issue Mar 2, 2024 · 1 comment · May be fixed by #2458
Open

FhirEngine instance creation should be decoupled from Database instance #2457

MJ1998 opened this issue Mar 2, 2024 · 1 comment · May be fixed by #2458
Labels
effort:small Small effort - 2 days P2 Medium priority issue type:code health

Comments

@MJ1998
Copy link
Collaborator

MJ1998 commented Mar 2, 2024 •
edited

Describe the Issue
I think there is a possibility of someone wanting to re-initialize FhirEngine instance while still maintaining the same database. Few reasons:-

  1. library enforced API changes in FhirEngineConfiguration. Application is forced to re-initialize the FhirEngine.
  2. Application wants to sync to a different server. Application wants to re-initialize here.

But above or any changes in the FhirEngineConfiguration API will most likely lead to backward incompatibility.
We would need to do versioning to solve for this.

So that this does not become a breaking change in future, when FhirEngineConfiguration API is modified, we should decouple database instance from the FhirEngine instance creation.

Would you like to work on the issue?
@MJ1998 MJ1998 changed the title Make FhirEngineConfiguration more readable FhirEngineConfiguration should be accepted via a configuration file Mar 2, 2024
This was referenced Mar 2, 2024
Open
Draft
@aditya-07 aditya-07 added type:code health effort:small Small effort - 2 days P2 Medium priority issue labels Mar 4, 2024
@MJ1998 MJ1998 changed the title FhirEngineConfiguration should be accepted via a configuration file FhirEngine instance should be decoupled from Database instance Mar 5, 2024
@MJ1998 MJ1998 changed the title FhirEngine instance should be decoupled from Database instance FhirEngine instance creation should be decoupled from Database instance Mar 5, 2024
@MJ1998
Copy link
Collaborator Author

MJ1998 commented Mar 5, 2024

@aditya-07
Discussion with @jingtang10 lead me to modify the issue. I think this is more urgent. PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort:small Small effort - 2 days P2 Medium priority issue type:code health
Projects
Android FHIR SDK
Status: New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configuration API changes MJ1998/android-fhir
2 participants
@aditya-07 @MJ1998