Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration API changes #2458

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Configuration API changes #2458

wants to merge 1 commit into from

Conversation

MJ1998
Copy link
Collaborator

@MJ1998 MJ1998 commented Mar 2, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2457

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-07 aditya-07 Awaiting requested review from aditya-07 aditya-07 will be requested when the pull request is marked ready for review aditya-07 is a code owner

@jingtang10 jingtang10 Awaiting requested review from jingtang10 jingtang10 will be requested when the pull request is marked ready for review jingtang10 is a code owner

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle santosh-pingle will be requested when the pull request is marked ready for review santosh-pingle is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FhirEngine instance creation should be decoupled from Database instance
1 participant
@MJ1998