Custom resource future support

[FikriMilano]

Custom Resource is not created and showing no stacktrace/error.

I was trying to insert a custom resource called LocationHierarchy into the FHIR engine database. I know it's not supported yet and I expect to receive some stacktrace/error, but turns out nothing show up and the custom resource is not inserted as well.

https://github.com/opensrp/fhir-common-utils/blob/main/src/main/java/org/smartregister/model/location/LocationHierarchy.java

@omarismail94 this is what I found out.

[omarismail94]

@FikriMilano I added the test below locally in DatabaseImplTest where I create a LocationHierarchy, save it, then read it from the DB and verify it matches the in-memory object I made and it passed:

  @Test
  fun insert_customResourceInDb() = runBlocking {

    val locationHierarchy = LocationHierarchy().setAddress(Address().setCity("Quincy")).setId("123")

    database.insert(locationHierarchy)
    testingUtils.assertResourceEquals(
      locationHierarchy,
      database.select(ResourceType.Bundle, "123")
    )


  }

I chose ResourceType.Bundle in the select statement as that is the type defined in the LocationHierarchy:
https://github.com/opensrp/fhir-common-utils/blob/main/src/main/java/org/smartregister/model/location/LocationHierarchy.java#L66

I also saved the files in the location directory to a directory in the SDK test path so they can be instantiated.

I uploaded the work I did to a new branch here: https://github.com/omarismail94/android-fhir/blob/custom_resource/engine/src/androidTest/java/com/google/android/fhir/db/impl/DatabaseImplTest.kt#L101-L110

Can you either clone it to see if it works for you, or share with me an example of a LocationHierarchy that fails to get saved (I know my example was simple)?

CC: @jingtang10

[omarismail94]

Also, there were literally nothing to see (no logs or crashes) when the resource fails to save.

Did you check the Database Inspector (if you are using an Emulator) to see if the DB holds any resources? If so, can you upload a screenshot of the view you see when you try to save things?

[FikriMilano]

I just tried to save the LocationHierarchy that you wrote, and it was a success :D (thank you)

val location_id = "123"
val locationHierarchy =
      LocationHierarchy().setAddress(Address().setCity("Quincy")).setId(location_id)

But then I tried to save the LocationHierarchy that I have and it was a fail.
It seems the problems lays in the resource itself (what do you think?).
I will investigate further.

[FikriMilano]

And yes I'm using Database Inspector, here's the screenshot (the successful one from your LocationHierarchy).

[FikriMilano]

If it's the LocationHierarchy that I have, the Database Inspector doesn't have that LocationHierarchy resource saved.

[omarismail94]

@FikriMilano sorry I was out on holidays for two weeks and am back today. Can you share the code that you use to build the LocationHierarchy object that fails to save?