Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of Xee #29

Open
alxmrs opened this issue Oct 3, 2023 · 0 comments
Open

Improve performance of Xee #29

alxmrs opened this issue Oct 3, 2023 · 0 comments
Labels
P1 Project

Comments

@alxmrs
Copy link
Collaborator

alxmrs commented Oct 3, 2023

I've noticed a regression in performance of Xee from the time we've introduced micro benchmarks.

Before:

open_dataset():avg=11.89,std=3.99,best=6.71,worst=22.73
open_and_chunk():avg=11.44,std=3.40,best=7.46,worst=20.65
open_and_write():avg=58.49,std=12.15,best=48.75,worst=84.94

Today:

open_dataset():avg=58.46,std=11.26,best=44.83,worst=76.46
open_and_chunk():avg=51.79,std=8.26,best=39.26,worst=69.36
open_and_write():avg=102.41,std=11.80,best=90.74,worst=129.80
@alxmrs alxmrs mentioned this issue Oct 3, 2023
Open
alxmrs pushed a commit that referenced this issue Oct 3, 2023
@alxmrs
Xee performance: Improving benchmarks.
85ebf22 
Makes improvements towards #29. Here, we group together all ee.getInfo() calls into one RPC call. In addition, this PR helped identify the underlying reason why Xee is slow (see #30).

Status Quo:
```
open_dataset():avg=51.30,std=10.21,best=39.41,worst=68.27
open_and_chunk():avg=52.94,std=7.01,best=43.06,worst=63.03
open_and_write():avg=113.94,std=27.35,best=90.03,worst=173.90
```

After:

```
open_dataset():avg=39.82,std=8.67,best=25.24,worst=55.54
open_and_chunk():avg=36.46,std=11.96,best=25.71,worst=59.83
open_and_write():avg=91.48,std=4.74,best=86.33,worst=104.08
```

PiperOrigin-RevId: 570480601
@alxmrs alxmrs mentioned this issue Oct 3, 2023
Closed
alxmrs pushed a commit that referenced this issue Oct 3, 2023
@alxmrs
Xee performance: Improving benchmarks.
00ccfc8 
Makes improvements towards #29. Here, we group together all ee.getInfo() calls into one RPC call. In addition, this PR helped identify the underlying reason why Xee is slow (see #30).

Status Quo:
```
open_dataset():avg=51.30,std=10.21,best=39.41,worst=68.27
open_and_chunk():avg=52.94,std=7.01,best=43.06,worst=63.03
open_and_write():avg=113.94,std=27.35,best=90.03,worst=173.90
```

After:

```
open_dataset():avg=39.82,std=8.67,best=25.24,worst=55.54
open_and_chunk():avg=36.46,std=11.96,best=25.71,worst=59.83
open_and_write():avg=91.48,std=4.74,best=86.33,worst=104.08
```

PiperOrigin-RevId: 570480601
alxmrs pushed a commit that referenced this issue Oct 4, 2023
@alxmrs
Xee performance: Improving benchmarks.
cafdac9 
Makes improvements towards #29. Here, we group together all ee.getInfo() calls into one RPC call. In addition, this PR helped identify the underlying reason why Xee is slow (see #30).

Status Quo:
```
open_dataset():avg=51.30,std=10.21,best=39.41,worst=68.27
open_and_chunk():avg=52.94,std=7.01,best=43.06,worst=63.03
open_and_write():avg=113.94,std=27.35,best=90.03,worst=173.90
```

After:

```
open_dataset():avg=39.82,std=8.67,best=25.24,worst=55.54
open_and_chunk():avg=36.46,std=11.96,best=25.71,worst=59.83
open_and_write():avg=91.48,std=4.74,best=86.33,worst=104.08
```

PiperOrigin-RevId: 570806762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 Project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alxmrs