Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined symbols when used as dependency of multiple targets (Swift Packages in Xcode) #408

Open
cjwirth opened this issue May 6, 2024 · 2 comments
Labels
bug Something isn't working triage Issues that need to be triaged

Comments

@cjwirth
Copy link

cjwirth commented May 6, 2024

Describe the bug
When building the app, I get undefined symbol errors, saying that it can't find symbols that exist in AppAuthCore:

ld: Undefined symbols:
  _OBJC_CLASS_$_OIDAuthState, referenced from:
       in GoogleSignIn.o
  _OBJC_CLASS_$_OIDAuthorizationRequest, referenced from:
       in GoogleSignIn.o
  _OBJC_CLASS_$_OIDAuthorizationService, referenced from:
       in GoogleSignIn.o
  _OBJC_CLASS_$_OIDIDToken, referenced from:
       in GoogleSignIn.o
  _OBJC_CLASS_$_OIDServiceConfiguration, referenced from:
       in GoogleSignIn.o
  _OBJC_CLASS_$_OIDURLQueryComponent, referenced from:
       in GoogleSignIn.o
  _OIDOAuthErrorResponseErrorKey, referenced from:
      +[GIDEMMSupport handleTokenFetchEMMError:completion:] in GoogleSignIn.o
  _OIDOAuthTokenErrorDomain, referenced from:
      ___53-[GIDGoogleUser refreshTokensIfNeededWithCompletion:]_block_invoke.22 in GoogleSignIn.o
  _OIDResponseTypeCode, referenced from:
      -[GIDSignIn authenticateInteractivelyWithOptions:] in GoogleSignIn.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This only happens if GoogleSignIn is added as a dependency of multiple targets that end up in the resulting app. If GoogleSignIn is only included into one target, it seems to be OK. But when it's included in multiple targets, I get the error above.

I have created a reproducible sample using the ObjC sample app provided by this repo.

To Reproduce
Steps to reproduce the behavior:

  1. Open the sample app in Xcode
  2. Create another Framework target that the main app depends on
  3. Make the new Framework target depend on GoogleSignIn
  4. Build the app -- see the errors

Or checkout the reproducible sample that I put together and try building it.

The app is basically structured like this in terms of project and dependencies:

.
└── AppTarget
    ├── GoogleSignIn
    ├── OnboardingFramework
    │   └── GoogleSignIn
    └── LoginFramework
        └── GoogleSignIn

Expected behavior
The app should build.

Screenshots
[available on request, but really nothing worth sharing, I don't think?]

Environment

  • GoogleSignIn-iOS Versions: 7.1.0, 6.2.4
  • Xcode: Have tried on Xcode 15.2, 15.3, and 15.4
  • OS: macOS 14.4.1, 14.5
@cjwirth cjwirth added bug Something isn't working triage Issues that need to be triaged labels May 6, 2024
@cjwirth cjwirth changed the title Undefined symbols when used as transitive dependency (Swift Packages in Xcode) Undefined symbols when used as dependency of multiple targets (Swift Packages in Xcode) May 13, 2024
@okuchmii
Copy link

okuchmii commented Jun 4, 2024

@cjwirth do you have any solution for this scenario as a workaround?

@cjwirth
Copy link
Author

cjwirth commented Jun 4, 2024

Unfortunately the only thing that has worked for me is to keep it in CocoaPods and not use the Package.

The only things I have issues with and need to use CocoaPods for are related to Google lol. Everything else has been fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issues that need to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants