You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#399 reverted GoogleSignInSwiftSupport.podspec's dependency on the GoogleSignIn pod to be 7.1+. This meant that the dependency for GSI in GoogleSignInSwiftSupport in the fac-eap branch did not match the version listed in GoogleSignIn.podspec, which was "7.1.0-fac-beta-1.1.0".
Problem
This mismatch, seemingly innocuous, led to pod lib lint failures (locally and PR runs) due to a version mismatch. Ultimately, the issue is that the pod lib lint command passed in the local GoogleSignIn.podspec, but linting GoogleSignInSwiftSupport.podspec would fail since the latter was looking for version 7.1+, and GoogleSignIn.podspec listed version "7.1.0-fac-beta-1.1.0".
To Do
#399 resolved the issue by updating unit_tests.yml to not use the local GoogleSignIn.podspec. This transformed the failing command:
pod lib lint GoogleSignInSwiftSupport.podspec --verbose \
--sources=https://cdn.cocoapods.org/ \
--include-podspecs='GoogleSignIn.podspec'
to this passing version:
pod lib lint GoogleSignInSwiftSupport.podspec --verbose \
--sources=https://cdn.cocoapods.org/ \
When we merge fac-eap to the main branch, we should reenable using the local podspec. We should also make sure that the version of GSI listed in GoogleSignInSwiftSupport.podspec matches the version in GoogleSignIn.podspec.
The text was updated successfully, but these errors were encountered:
Context
#399 reverted
GoogleSignInSwiftSupport.podspec
's dependency on the GoogleSignIn pod to be 7.1+. This meant that the dependency for GSI inGoogleSignInSwiftSupport
in thefac-eap
branch did not match the version listed inGoogleSignIn.podspec
, which was"7.1.0-fac-beta-1.1.0"
.Problem
This mismatch, seemingly innocuous, led to
pod lib lint
failures (locally and PR runs) due to a version mismatch. Ultimately, the issue is that thepod lib lint
command passed in the localGoogleSignIn.podspec
, but lintingGoogleSignInSwiftSupport.podspec
would fail since the latter was looking for version 7.1+, andGoogleSignIn.podspec
listed version"7.1.0-fac-beta-1.1.0"
.To Do
#399 resolved the issue by updating
unit_tests.yml
to not use the localGoogleSignIn.podspec
. This transformed the failing command:to this passing version:
When we merge
fac-eap
to themain
branch, we should reenable using the local podspec. We should also make sure that the version of GSI listed inGoogleSignInSwiftSupport.podspec
matches the version inGoogleSignIn.podspec
.The text was updated successfully, but these errors were encountered: