Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift-button-functional-test job failing due to changes in sign in flow #367

Open
mdmathias opened this issue Feb 10, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working triage Issues that need to be triaged

Comments

@mdmathias
Copy link
Collaborator

The swift-button-functional-test job appears to no longer pass, likely due to changes in the sign in flow. I was able to get parts of the test case to pass, but not reliably. Running locally on a simulator, I would occasionally see the sign in flow succeed, and other times I would see a screen telling me that Safari was unable to contact the server.

Since this test is not passing, and is blocking the beta release of AppCheck support within GSI, I am going to disable this job. This is not harmful since this test is completely unrelated to AppCheck, and the AppCheck tests (including integration) are passing.

We should nonetheless follow up on this and fix the issue.

@mdmathias mdmathias added bug Something isn't working triage Issues that need to be triaged labels Feb 10, 2024
@mdmathias mdmathias self-assigned this Feb 10, 2024
@mdmathias
Copy link
Collaborator Author

Need to make sure to re-enable this test and revert the if check back to if: "!github.event.pull_request.head.repo.fork".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issues that need to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants