Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleSignIn required to be signed in Xcode #105

Open
jkichline opened this issue Mar 3, 2022 · 15 comments · May be fixed by #226
Open

GoogleSignIn required to be signed in Xcode #105

jkichline opened this issue Mar 3, 2022 · 15 comments · May be fixed by #226

Comments

@jkichline
Copy link

This seems like a new development, but GoogleSignIn is being required to be signed. This is quite strange for a CocoaPod. This means I need to alter the Pods project and add the signing information to only the GoogleSignIn project. What is the deal with this? It's creating distribution headaches too.

@petea
Copy link
Contributor

petea commented Mar 17, 2022

@jkichline can you tell me how and at what point you're experiencing this requirement?

@jkichline
Copy link
Author

Here's a screenshot. You'll see that GoogleSignIn in the middle column is a different color than the other frameworks and requires it to be signed in order to submit it to the App Store. the other frameworks don't need this and can go unsigned. I need to go through and manually sign the frameworks and make sure I pick the correct options for iOS vs Mac Catalyst for each of my builds (debug, beta, release, distribution). While it wouldn't be too bad if I did this once, every time I "pod update", this information is lost and needs to be entered over and over again, and I need to run "pod update" every time I switch between branches in our code base which means I run the risk of having a failed upload to the App Store every time.
Screen Shot 2022-03-17 at 12 57 09 PM

Here is the warning/error we get from the App Store for the Mac Catalyst version if we don't get the settings correct. This means we need to submit another build.
Screen Shot 2022-03-17 at 1 02 24 PM

I guess I wonder why GoogleSignIn is any different from any other frameworks?

@cnjsyyb
Copy link

cnjsyyb commented Jun 15, 2022

xcode 14.0 beta has this problem.

@noppefoxwolf
Copy link

+1
Same problem.

@vapor-pawelw
Copy link

+1, same on xcode 14 beta 3

@vapor-pawelw
Copy link

@petea any plans here? Would be good to have this fixed unless this is some actual xcode 14 bug that Apple needs to resolve - I haven't investigated this, but it would be good to have this sorted out

@paulb777
Copy link
Member

Related discussion and possible workaround at firebase/firebase-ios-sdk#9886

@marwenmoalla
Copy link

+1

@AmineNac
Copy link

AmineNac commented Sep 14, 2022

+1, same on xcode 14.0

@johnnyasantoss
Copy link

johnnyasantoss commented Sep 26, 2022

Probably related to #226 and #223

@vikage
Copy link

vikage commented Oct 25, 2022

I faced this problem on Xcode 14.0 too.
I temporary solved it by disabling Code signing for Pod by adding these lines to bottom of Podfile

post_install do |installer|
  installer.generated_projects.each do |target|
      target.build_configurations.each do |config|
        config.build_settings['CODE_SIGNING_ALLOWED'] = "NO"
        config.build_settings['CODE_SIGNING_REQUIRED'] = "NO"
        config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = ""
      end
    end
end

@OS-ricardomoreirasilva
Copy link

I faced this problem on Xcode 14.0 too. I temporary solved it by disabling Code signing for Pod by adding these lines to bottom of Podfile

post_install do |installer|
  installer.generated_projects.each do |target|
      target.build_configurations.each do |config|
        config.build_settings['CODE_SIGNING_ALLOWED'] = "NO"
        config.build_settings['CODE_SIGNING_REQUIRED'] = "NO"
        config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = ""
      end
    end
end

On my side, this kind of fixed the issue.

Kind of because I have an app that contains an internal pod (via podspec) that contains GoogleSignIn and the solution only fixed the issue on the internal pod. Supposedly I would have to include this post_install statement on the internal pod's podspec but I think this is not possible. Any idea on how to overcome this?

@romas34
Copy link

romas34 commented Jan 31, 2023

/Users/romas/Documents/unity/xcode/yacht/Pods/Pods.xcodeproj Signing for "GoogleSignIn-GoogleSignIn" requires a development team. Select a development team in the Signing & Capabilities editor.

I can manually specify the Team ID in XCode. But it's not right for me. How can I do this automatically from Unity?

@romas34
Copy link

romas34 commented Feb 3, 2023

Workaround fix from Unity. I added these lines to the end of the podfile in OnPostprocessBuild() method:

plugin 'cocoapods-pod-sign'
skip_pod_bundle_sign

Also I ran the command on the Mac:
$ gem install cocoapods-pod-sign

@puopg
Copy link

puopg commented Mar 31, 2023

Installing CocoaPods 1.12.0 resolved this issue for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.