Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight refactor, eventually #22

Open
patrick-kidger opened this issue Aug 16, 2020 · 1 comment
Open

Slight refactor, eventually #22

patrick-kidger opened this issue Aug 16, 2020 · 1 comment

Comments

@patrick-kidger
Copy link
Collaborator

patrick-kidger commented Aug 16, 2020

Not suggesting that this happen now; I'm just opening an issue to keep track of it.

I think the current hierarchy of:

_brownian
_core
    methods
brownian_lib
_brownian_lib [from C++]

(not counting _core/adjoint_sdes which I know you've removed in your latest branch)

should be switched to:

_impl
    brownian
    methods
    core

(So additionally tidying the Brownian things together somehow. If we end up implementing every Brownian* in C++ then that would suffice, for example.)

@lxuechen
Copy link
Collaborator

Agree. This refactoring seems sensible, and should come in when we have the C++ implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants