We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google-research/d3pm/images/diffusion_categorical.py
Lines 448 to 452 in 52222c0
Here, we can see that p_logit function is returning logit of prediction of x_0 if t == 0, otherwise q_posterior. which is understandable,
However, looking at the q_posterior_logits method, we can see that it is already returning x_start if t is 0.
q_posterior_logits
x_start
Lines 423 to 425 in 52222c0
So I think we don't need this LOC, am I missing something?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
google-research/d3pm/images/diffusion_categorical.py
Lines 448 to 452 in 52222c0
Here, we can see that p_logit function is returning logit of prediction of x_0 if t == 0, otherwise q_posterior. which is understandable,
However, looking at the
q_posterior_logits
method, we can see that it is already returningx_start
if t is 0.google-research/d3pm/images/diffusion_categorical.py
Lines 423 to 425 in 52222c0
So I think we don't need this LOC, am I missing something?
The text was updated successfully, but these errors were encountered: