Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.1.5 dist build is not transpiled #60

Closed
timothympace opened this issue Dec 9, 2020 · 2 comments · Fixed by #61
Closed

Version 2.1.5 dist build is not transpiled #60

timothympace opened this issue Dec 9, 2020 · 2 comments · Fixed by #61
Labels
enhancement New feature or request

Comments

@timothympace
Copy link

Describe the bug A clear and concise description of what the bug is.

This module is not being transpiled to a distributable that can be used easily. There are two problems I'm running into with webpack.

  1. There is an import React from 'react'; statement in index.js.
  2. It is compiled to ES6+ language level and requires babel to transpile it.

Is it possible to create a dist that is ES5 compatible?

To Reproduce Steps to reproduce the behavior:

  1. import the module in code
  2. bundle with webpack/babel
  3. failures unless this module is specifically included

Expected behavior A clear and concise description of what you expected to happen.

Should be able to include this in a webpack build with no additional configuration.

@timothympace timothympace added the bug Something isn't working label Dec 9, 2020
@socsieng
Copy link
Collaborator

socsieng commented Dec 9, 2020

Thanks for raising the issue. The intention here was that it would be bring-your-own transpiler/bundler. I can include an ES5 target, however, it will probably only be a minified version. Would that work?

Out of interest, how are you including this resource in your web page?

@socsieng socsieng added enhancement New feature or request and removed bug Something isn't working labels Dec 9, 2020
socsieng pushed a commit to socsieng/google-pay-button that referenced this issue Dec 9, 2020
@socsieng
Copy link
Collaborator

socsieng commented Dec 9, 2020

@timothympace, please have a look at #61 and let me know if it looks okay to you.

socsieng pushed a commit to socsieng/google-pay-button that referenced this issue Feb 6, 2021
socsieng pushed a commit to socsieng/google-pay-button that referenced this issue Feb 6, 2021
socsieng pushed a commit that referenced this issue Feb 6, 2021
socsieng pushed a commit that referenced this issue Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants