Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable inferrence if/when we agree as a team #13

Closed
socsieng opened this issue Jun 16, 2020 · 0 comments
Closed

Re-enable inferrence if/when we agree as a team #13

socsieng opened this issue Jun 16, 2020 · 0 comments

Comments

@socsieng
Copy link
Collaborator

socsieng commented Jun 16, 2020 •
edited

Code that inferred request parameters based on the presence of other values was removed to keep the button API consistent with the loadPaymentData request parameters.

The downside to this is that unless developers read the API documentation, exploring the API and just trying things out could increase the chances that the user receives an error.

I would like to revisit this and re-enable this type of inference if we can get consensus on this approach.
socsieng pushed a commit that referenced this issue Jun 16, 2020
feat!: remove logic to infer callbackIntents based on callback methods
49e5ad2 
Need to discuss with the rest of the team about whether or not this logic should be introduced.

Issue #13 has been raised to track this.
socsieng pushed a commit that referenced this issue Jun 16, 2020
revert!: remove logic to infer callbackIntents based on callback methods
478194d 
Revert "feat!: remove logic to infer callbackIntents based on callback methods"

Fixes #13

This reverts commit 49e5ad2.
@socsieng socsieng mentioned this issue Jun 16, 2020
Closed
socsieng pushed a commit that referenced this issue Jun 17, 2020
feat!: remove logic to infer paymentRequest properties
3261957 
Related to #13
socsieng pushed a commit that referenced this issue Jun 17, 2020
revert!: remove logic to infer paymentRequest properties
856d54a 
Revert "feat!: remove logic to infer paymentRequest properties"

For #13

This reverts commit 3261957.
socsieng pushed a commit that referenced this issue Jun 17, 2020
revert!: remove logic to infer callbackIntents based on callback methods
b36e73a 
Revert "feat!: remove logic to infer callbackIntents based on callback methods"

For #13

This reverts commit 49e5ad2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revert!: restore inference paymentRequest inference logic google-pay/google-pay-button
1 participant
@socsieng