Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent path processing for .gcloudignore #358

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eddielin0926
Copy link

Using the repo root for finding ignore files since this action uses the top-level .glcoudignore.

The testcase processes a gcloudignore does not use a longer path in .gcloudignore. Since the given path is testdata, the behavior should remain the same after changing *.txt to testdata/**/*.txt in the testcase.

@eddielin0926 eddielin0926 requested a review from a team as a code owner April 26, 2024 22:06
Copy link

google-cla bot commented Apr 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent path processing for .gcloudignore
1 participant