Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent path processing for .gcloudignore #357

Open
eddielin0926 opened this issue Apr 15, 2024 · 2 comments · May be fixed by #358
Open

Inconsistent path processing for .gcloudignore #357

eddielin0926 opened this issue Apr 15, 2024 · 2 comments · May be fixed by #358
Labels
bug Something isn't working

Comments

@eddielin0926
Copy link

TL;DR

The issue pertains to inconsistent path processing when the given path is treated as the root directory, but the top-level .gcloudignore is utilized. Therefore, the path in .gcloudignore is concatenated with the given path variable.

Expected behavior

The paths listed in .gcloudignore should be calculated from the path of .gcloudignore.

Observed behavior

No response

Action YAML

- id: 'upload-file'
  uses: 'google-github-actions/upload-cloud-storage@v2'
  with:
    path: '/path/to/file'
    destination: 'bucket-name'
    process_gcloudignore: true

Log output

No response

Additional information

No response

@eddielin0926 eddielin0926 added the bug Something isn't working label Apr 15, 2024
@sethvargo
Copy link
Member

How does gcloud behave here? I believe we mirrored the same functionality.

@eddielin0926
Copy link
Author

How does gcloud behave here? I believe we mirrored the same functionality.

gcloud does not always use the top-level .gcloudignore. It uses the .gcloudignore located in the given directory.

Here is an example.

$ mkdir -p example/upload && cd example
$ echo "upload/a.txt" > .gcloudignore
$ echo "b.txt" > upload/.gcloudignore
$ touch upload/a.txt upload/b.txt
$ gcloud meta list-files-for-upload
.gcloudignore
upload/.gcloudignore
upload/b.txt
$ gcloud meta list-files-for-upload upload
.gcloudignore
a.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants