Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing gcloudignore path #336

Open
shaharkazaz opened this issue Jul 20, 2023 · 0 comments
Open

Allow passing gcloudignore path #336

shaharkazaz opened this issue Jul 20, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shaharkazaz
Copy link

shaharkazaz commented Jul 20, 2023

TL;DR

I have different upload cases where I need different things to be ignored, it's difficult managing it all inside a single gcloudignore file.

I would like the ability to pass the path to the file as an input so I can use different ignore configurations for each one of my cases.
My current workaround is not processing it and passing glob/different upload paths which makes the code less readable and unclear because sometimes I'm not processing it and sometimes I don't.

Detailed design

Usage example:

        uses: 'google-github-actions/upload-cloud-storage@v1'
        with:
          path: 'dist/my/app'
          gcloudignore_path: '.gcloudignore.dev'

Additional information

No response

@shaharkazaz shaharkazaz added the enhancement New feature or request label Jul 20, 2023
@sethvargo sethvargo added the good first issue Good for newcomers label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

2 participants