Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable load test #250

Open
sethvargo opened this issue Apr 8, 2022 · 0 comments
Open

Re-enable load test #250

sethvargo opened this issue Apr 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@sethvargo
Copy link
Member

sethvargo commented Apr 8, 2022

TL;DR

The current load test can only run 3x in a short period and then we hit quota limits. This makes iterative testing and debugging extremely painful, so it's disabled.

Detailed design

We need to re-enable the load test. Ideas:

  • Move to a separate action that are allowed to fail
  • Only run on pushes to main (not on PRs)
  • Run on a cron schedule instead of on PRs and pushes

There also seems to be something weird with the authentication. The error messages we get are actually 503s from the STS service. It seems like the NPM package for Storage is doing an auth handshake for each file upload. I don't have more advanced telemetry to prove this, but that feels like a bug. The token should be cached and reused for its TTL /cc @bcoe

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant