Add optional credentials_file_path input for setup-gcloud #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricker
force-pushed
the
bcr/202007/creds_path
branch
4 times, most recently
from
d055c05
to
515e778
Compare
bricker
force-pushed
the
bcr/202007/creds_path
branch
from
515e778
to
8307ceb
Compare
|
@sethvargo How can I get this reviewed and merged? |
|
Hi @bricker, I'll review this shortly. I want to note that we are working on a new process for merging external contributions. |
averikitsch
approved these changes
Oct 9, 2020
| @@ -34,7 +34,7 @@ module.exports = | |||
| /******/ // the startup function | |||
There was a problem hiding this comment.
This file is built and added in a pre-commit hook (via Husky). Do you want me to delete this file, or just revert my changes? And should I remove the git hook too?
There was a problem hiding this comment.
The pre-commit hook has been removed. Please revert the changes to the dist/index.js. We will be generating this file as a part of our release process.
Co-authored-by: Averi Kitsch <akitsch@google.com>
|
merging into a testing branch |
averikitsch
added a commit
that referenced
this pull request
Oct 27, 2020
#213) * Add optional credentials_file_path input for setup-gcloud (#153) * Add optional credentials_file_path input to setup-gcloud * Update setup-gcloud/tests/setup-gcloud.test.ts Co-authored-by: Averi Kitsch <akitsch@google.com> Co-authored-by: Averi Kitsch <akitsch@google.com> * Respond to comments * lint * update timeout Co-authored-by: Bryan Ricker <bryancricker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-144
setup-gcloudwhich allows the caller to override the path at which the credentials are saved on disk. If not provided, the previous behavior (usingGITHUB_WORKSPACE) is maintained.