Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RUNNER_TEMP to export credentials #148

Merged
merged 1 commit into from Jul 21, 2020
Merged

Use RUNNER_TEMP to export credentials #148

merged 1 commit into from Jul 21, 2020

Conversation

sethvargo
Copy link
Member

Fixes GH-144

@sethvargo sethvargo mentioned this pull request Jul 21, 2020
Closed
bharathkkb
bharathkkb approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethvargo sethvargo merged commit 191a0f3 into master Jul 21, 2020
@sethvargo sethvargo deleted the sethvargo/export_path branch July 21, 2020 14:42
@sethvargo sethvargo restored the sethvargo/export_path branch July 22, 2020 11:56
@sethvargo sethvargo deleted the sethvargo/export_path branch July 22, 2020 11:56
sethvargo added a commit that referenced this pull request Jul 22, 2020
@sethvargo
Revert "Use RUNNER_TEMP to export credentials (#148)"
27b86f0 
This reverts commit 191a0f3.
@sethvargo sethvargo mentioned this pull request Jul 22, 2020
Merged
sethvargo added a commit that referenced this pull request Jul 22, 2020
@sethvargo
Revert "Use RUNNER_TEMP to export credentials" (#149)
0926395 
* Revert "Use RUNNER_TEMP to export credentials (#148)"

This reverts commit 191a0f3.

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

export_default_credentials should place credentials outside of the workspace
2 participants
@sethvargo @bharathkkb