feat: support gcloudignore #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voxpelli
reviewed
Jun 2, 2021
Comment on lines
-59
to
+62
| archive.directory(dirPath, false); | ||
| getFiles(dirPath).forEach((filepath) => { |
There was a problem hiding this comment.
Did you see that archive.directory() can take a third argument, which as far as I can see is a callback that can be used for some kind of filtering? https://github.com/archiverjs/node-archiver/blob/f6c9cc2fa6a167594c82428faf22dc59dbba7404/lib/core.js#L658-L661
There was a problem hiding this comment.
Hi @voxpelli, thanks for the review.
I tried to do this with just archiver but found that all filtering in archiver is done via minimatch which did not work due to isaacs/minimatch#46. So for example, this test was failing https://github.com/google-github-actions/deploy-cloud-functions/blob/support-gcloudignore/tests/test-func-ignore-node/.gcloudignore
averikitsch
approved these changes
Jun 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36