Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function labels support #60

Merged
merged 2 commits into from
May 26, 2021

Conversation

nilcolor
Copy link
Contributor

@nilcolor nilcolor commented May 15, 2021

Adds a new parameter for the action - labels. Can be something like

      - uses: google-github-actions/deploy-cloud-functions@main
        with:
          name: function-demo
          runtime: node12
          entry_point: hello_world
          memory_mb: 128
          labels: env=demo,version=${{ github.sha }}

Works almost the same way as Env variables. But sets "labels": { string: string, ... }, part of the CloudFunction object.

@nilcolor nilcolor requested a review from a team as a code owner May 15, 2021 19:30
@google-cla
Copy link

google-cla bot commented May 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 15, 2021
@github-actions github-actions bot added the Fork label May 15, 2021
@nilcolor
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels May 15, 2021
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nilcolor

src/cloudFunction.ts Outdated Show resolved Hide resolved
src/cloudFunction.ts Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the base branch from main to pr-60 May 26, 2021 02:36
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and adding tests!

@bharathkkb bharathkkb merged commit fc9d163 into google-github-actions:pr-60 May 26, 2021
bharathkkb added a commit that referenced this pull request May 26, 2021
* feat: add function labels support (#60)

* feat: add function labels support

* fix: apply changes based on code review

* Document label input in readme

Co-authored-by: Alexey Blinov <nilcolor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants