Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix zip file creation, improve logs #48

Merged
merged 3 commits into from
Feb 25, 2021
Merged

feat: fix zip file creation, improve logs #48

merged 3 commits into from
Feb 25, 2021

Conversation

bharathkkb
Copy link
Contributor

fixes #41

  • only resolve zip creation on finish event
  • added more logs for insights incase of zip errors as recommended by Archiver

@bharathkkb bharathkkb requested a review from a team as a code owner February 21, 2021 21:18
@google-cla google-cla bot added the cla: yes label Feb 21, 2021
@bharathkkb bharathkkb mentioned this pull request Feb 21, 2021
Closed
@bharathkkb bharathkkb mentioned this pull request Feb 22, 2021
Closed
averikitsch
averikitsch suggested changes Feb 22, 2021
View reviewed changes
src/cloudFunctionClient.ts Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit c084c5e into main Feb 25, 2021
@bharathkkb bharathkkb deleted the zip-logs branch February 25, 2021 01:09
@google-github-actions-bot google-github-actions-bot mentioned this pull request Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy uploads corrupt zip
2 participants
@bharathkkb @averikitsch