Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add security_level field for https triggers #266

Merged
merged 1 commit into from
Jan 20, 2022
Merged

feat: add security_level field for https triggers #266

merged 1 commit into from
Jan 20, 2022

Conversation

sethvargo
Copy link
Member

@sethvargo sethvargo commented Jan 19, 2022 •
edited

Fixes #261

@sethvargo sethvargo requested a review from a team as a code owner January 19, 2022 14:52
@sethvargo sethvargo mentioned this pull request Jan 19, 2022
Closed
bharathkkb
bharathkkb reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also in favor of the secure option. We could add a call out to the readme like https://github.com/google-github-actions/deploy-cloud-functions#allow-unauthenticated-requests

src/main.ts Outdated
@@ -111,6 +114,12 @@ async function run(): Promise<void> {
}

// Validation
if (httpsTriggerSecurityLevel && eventTriggerType) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since https_trigger_security_level has a default wouldn't httpsTriggerSecurityLevel be truthy by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. It turns out that it's easier to fix this if we set the default value to "SECURITY_LEVEL_UNSPECIFIED" (same as gcloud).

@sethvargo sethvargo merged commit aa3a2aa into main Jan 20, 2022
@sethvargo sethvargo deleted the sethvargo/security_level branch January 20, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch is a code owner automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add support for security-level flag
2 participants
@sethvargo @bharathkkb