feat: Merge EnvVars and EnVarsFile #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averikitsch
reviewed
Jul 29, 2021
| 'Only one of env_vars or env_vars_file can be specified.', | ||
| ); | ||
| } | ||
| if (opts?.envVars || opts?.envVarsFile) { |
There was a problem hiding this comment.
nit: Can you add a comment on what's happening here?
There was a problem hiding this comment.
Done!
thank you for the feedback!
averikitsch
changed the title
averikitsch
approved these changes
Jul 29, 2021
bharathkkb
approved these changes
Jul 30, 2021
bharathkkb
added a commit
that referenced
this pull request
Jul 30, 2021
* Fix issue#57 by merging envVars and envVarsFile together * Added to explain the logic for `envVars` and `envVarsFile` Co-authored-by: Averi Kitsch <akitsch@google.com> Co-authored-by: Piolin Victor <victor.piolin@gmail.com> Co-authored-by: Averi Kitsch <akitsch@google.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #57
Got the same need for one of my project, this is proposition to merge
envVarsandenvVarsFile