Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose deploy timeout as an action input #125

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Expose deploy timeout as an action input #125

merged 2 commits into from
Jul 21, 2021

Conversation

xylo04
Copy link
Contributor

@xylo04 xylo04 commented Jul 21, 2021

Resolves #124

@xylo04 xylo04 requested a review from a team as a code owner July 21, 2021 12:48
@google-cla google-cla bot added the cla: yes label Jul 21, 2021
@github-actions github-actions bot added the Fork label Jul 21, 2021
bharathkkb
bharathkkb reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@bharathkkb bharathkkb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @xylo04
Could you also update the readme with new input? Sorry missed that you already did :)

@bharathkkb bharathkkb changed the base branch from main to pr-125 July 21, 2021 17:43
@bharathkkb bharathkkb merged commit d72fed6 into google-github-actions:pr-125 Jul 21, 2021
bharathkkb added a commit that referenced this pull request Jul 21, 2021
@bharathkkb @xylo04
feat: expose deploy timeout as an action input (#125) (#128)
2623495 
Resolves #124

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>

Co-authored-by: Chris Keller <xylo04@gmail.com>
@google-github-actions-bot google-github-actions-bot mentioned this pull request Jul 21, 2021
Merged
xylo04 added a commit to k0swe/forester-func that referenced this pull request Jul 21, 2021
@xylo04
Increase deploy timeout
b992092 
Takes advantage of google-github-actions/deploy-cloud-functions#125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose timeout as an action parameter
2 participants
@xylo04 @bharathkkb