Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose timeout as an action parameter #124

Closed
xylo04 opened this issue Jul 21, 2021 · 1 comment · Fixed by #125 or #128
Closed

Expose timeout as an action parameter #124

xylo04 opened this issue Jul 21, 2021 · 1 comment · Fixed by #125 or #128

Comments

@xylo04
Copy link
Contributor

xylo04 commented Jul 21, 2021 •
edited

TL;DR

Despite increasing timeout from 200 to 300 seconds in #46, I'm still seeing many timeouts: https://github.com/k0swe/forester-func/actions/workflows/deploy.yml. Let's please expose timeout as an input as suggested in #46 (review). It would be ideal if this were a friendly timespec (10m instead of 600 with implied units) but that's more work.

Design

Action YAML

      - name: Cloud Functions Deploy ImportQrz
        uses: google-github-actions/deploy-cloud-functions@main
        with:
          name: ImportQrz
          entry_point: ImportQrz
          runtime: go113
          env_vars: GCP_PROJECT=k0swe-kellog
          deploy_timeout: 600

Resources
#45 and #46
@xylo04
Copy link
Contributor Author

xylo04 commented Jul 21, 2021

I just realized that timeout is already on the action, and it's the function execution timeout. Perhaps this should be deploy_timeout.

@xylo04 xylo04 mentioned this issue Jul 21, 2021
Merged
bharathkkb added a commit that referenced this issue Jul 21, 2021
@xylo04 @bharathkkb
feat: expose deploy timeout as an action input (#125)
d72fed6 
Resolves #124

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
@bharathkkb bharathkkb mentioned this issue Jul 21, 2021
Merged
bharathkkb added a commit that referenced this issue Jul 21, 2021
@bharathkkb @xylo04
feat: expose deploy timeout as an action input (#125) (#128)
2623495 
Resolves #124

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>

Co-authored-by: Chris Keller <xylo04@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@xylo04