Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve env var parsing behaviour #122

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Improve env var parsing behaviour #122

merged 2 commits into from
Jul 21, 2021

Conversation

robcowie
Copy link
Contributor

Fixes #111

@robcowie
fix(envVars): Handle multiple delimiters when parsing
2fbd3b7 
Split a key/val pair only on the first equals character, preserving
any remaining equals characters in the key and value.
@robcowie
test(envVars): Test env var string parsing with multiple delim chars
cc5c38c
@robcowie robcowie requested a review from a team as a code owner July 20, 2021 08:28
@google-cla google-cla bot added the cla: yes label Jul 20, 2021
@github-actions github-actions bot added the Fork label Jul 20, 2021
bharathkkb
bharathkkb approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @robcowie

@bharathkkb bharathkkb changed the base branch from main to pr-122 July 21, 2021 16:44
@bharathkkb bharathkkb merged commit febb75d into google-github-actions:pr-122 Jul 21, 2021
bharathkkb added a commit that referenced this pull request Jul 21, 2021
@bharathkkb @robcowie
fix: improve env var parsing behaviour (#122) (#126)
199d134 
* fix(envVars): Handle multiple delimiters when parsing

Split a key/val pair only on the first equals character, preserving
any remaining equals characters in the key and value.

* test(envVars): Test env var string parsing with multiple delim chars

Co-authored-by: Rob Cowie <rob_cowie@mac.com>
@google-github-actions-bot google-github-actions-bot mentioned this pull request Jul 21, 2021
Merged
@robcowie robcowie deleted the improve-env-var-parsing-behaviour branch July 22, 2021 15:57
@bharathkkb bharathkkb mentioned this pull request Aug 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

envVars fails when the value has '=' querystring
2 participants
@robcowie @bharathkkb