Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for cosine decay schedule #905

Open
gjhuizing opened this issue Apr 4, 2024 · 2 comments
Open

Documentation for cosine decay schedule #905

gjhuizing opened this issue Apr 4, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@gjhuizing
Copy link

gjhuizing commented Apr 4, 2024

Hello,

The formula in the documentation for the cosine_decay_schedule (https://optax.readthedocs.io/en/latest/api/optimizer_schedules.html#optax.cosine_decay_schedule) would suggest that the learning rate increases again after T steps.

A quick look at the code confirms this is not the case, but it may be good to write it explicitly, as in linear_schedule.

Happy to make a short PR! I also could propose a short formula/pseudocode for functions like piecewise_constant_schedule that do not have one.

Best

GJ

@vroulet
Copy link
Collaborator

vroulet commented Apr 4, 2024

Hello @gjhuizing,

Thanks for catching this! If you are willing to do such a PR that would be great!

@gjhuizing
Copy link
Author

Great!

@vroulet vroulet added documentation Improvements or additions to documentation good first issue Good for newcomers labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants