Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default epsilon values for AdaBelief don't match the paper #440

Open
danijar opened this issue Oct 16, 2022 · 0 comments
Open

Default epsilon values for AdaBelief don't match the paper #440

danijar opened this issue Oct 16, 2022 · 0 comments
Assignees

Comments

@danijar
Copy link

danijar commented Oct 16, 2022

In the AdaBelief paper, there is only one epsilon = 1e-8 that is used both to damp the second moment estimate and as constant in the denominator. In Optax, there are instead eps = 1e-16 and root_eps = 1e-16. Initially, I just set eps = 1e-8 in the hope to match the paper, but just no noticed that I also need to set root_eps = 1e-1. A few ideas how this might be improved:

  • Add a note in the documentation
  • Use the defaults eps = 1e-8 and root_eps = None and the set if root_eps is None: root_eps = eps
  • At least default eps = 1e-8 and root_eps = 1e-8
    Is there a particular reason the implementation uses different default hparams?
@mkunesch mkunesch assigned mkunesch and mtthss and unassigned mkunesch Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants