Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About Predictive CFR+ #1113

Open
rpSebastian opened this issue Aug 28, 2023 · 2 comments
Open

About Predictive CFR+ #1113

rpSebastian opened this issue Aug 28, 2023 · 2 comments
Labels
contribution welcome It's a nice feature! But we do not have the time to do it ourselves. Contribution welcomed!

Comments

@rpSebastian
Copy link

Hi! Is there a plan to include predictive CFR+ implementation in open spiel? https://arxiv.org/abs/2007.14358
@lanctot lanctot added the contribution welcome It's a nice feature! But we do not have the time to do it ourselves. Contribution welcomed! label Aug 28, 2023
@lanctot
Copy link
Collaborator

lanctot commented Aug 28, 2023

We don't have any plans to do it, but it would make a great contribution! If you implement it, I encourage you to submit a PR.

@maichmueller
Copy link
Contributor

maichmueller commented Oct 31, 2023 •
edited

Hi @rpSebastian ,

I implemented PCFR+ here using open_spiel as basis a while ago. It does not reach the performance of the paper (so unsure about correctness) in e.g. Kuhn Poker but is a couple of magnitudes faster to converge than CFR+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome It's a nice feature! But we do not have the time to do it ourselves. Contribution welcomed!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lanctot @maichmueller @rpSebastian