Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJX model versions #58

Closed
peterdavidfagan opened this issue May 17, 2024 · 4 comments
Closed

MJX model versions #58

peterdavidfagan opened this issue May 17, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@peterdavidfagan
Copy link

peterdavidfagan commented May 17, 2024

Which model is the issue affecting?

All model releases (in particular those models containing features that are supported in mujoco but not mujoco-mjx).

What is the issue?

It would be nice if model releases include mjx compatible versions. Models that contain tendons for instance are not supported in mjx, right now users have to alter published models containing tendons to use them with mjx, it would be nice if there was official support for mjx compatible models.

Is there any additional context you can provide (e.g., a spec sheet or a URDF to show a value mismatch)?

I have been trying to use the robotiq_2f85 model with mjx but I have encountered the following error:

 File "/home/peter/.cache/pypoetry/virtualenvs/mujoco-robot-environments-hs2qeFWj-py3.10/lib/python3.10/site-packages/mujoco/mjx/_src/io.py", line 69, in put_model
    raise NotImplementedError('tendons are not supported')
NotImplementedError: tendons are not supported

Update: my bad I see that tendons will be supported in future, maybe the main thing is to wait for feature parity. Although there are other important considerations like the integrator and collision geometries for which it may be worth supporting another file for mjx.

@peterdavidfagan peterdavidfagan added the bug Something isn't working label May 17, 2024
@kevinzakka
Copy link
Collaborator

Hi @peterdavidfagan, we do have MJX-compatible models for certain robots, e.g. see anymal C, Unitree Go2 and Google Barkour robots. Not all models are simulate-able in MJX due to lack of feature parity, but having an MJX-version for all robots that support it is on our roadmap and we are actively accepting community contributions! I'll add an MJX column to the README table to make this more visible.

@peterdavidfagan
Copy link
Author

Ah ok understood, thanks @kevinzakka for clarifying this.

@kevinzakka
Copy link
Collaborator

@peterdavidfagan I just pushed a commit that improves the README. There should now be an MJX column in the main table telling you if an MJX-compatible model is available. Cheers!

@peterdavidfagan
Copy link
Author

Thanks @kevinzakka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants