Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ADD with getting files from a URL #38

Open
inductor opened this issue Jun 26, 2019 · 4 comments
Open

Allow ADD with getting files from a URL #38

inductor opened this issue Jun 26, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@inductor
Copy link
Contributor

inductor commented Jun 26, 2019

Description

FATAL	- CIS-DI-0009: Use COPY instead of ADD in Dockerfile
	* Use COPY : ADD https://github.com/jwilder/docker-gen/releases/download/0.7.4/docker-gen-linux-amd64-0.7.4.tar.gz /tmp/
	* Use COPY : ADD https://github.com/just-containers/s6-overlay/releases/download/v1.22.1.0/s6-overlay-amd64.tar.gz /tmp/
	* Use COPY : ADD https://raw.githubusercontent.com/diafygi/acme-tiny/5350420d35177eda733d85096433a24e55f8d00e/acme_tiny.py /bin/acme_tiny

This case ADD must be used.

What did you expect to happen?

What happened instead?

Output of run with -debug:

(paste your output here)

Output of dockle -v:

(paste your output here)

Additional details (base image name, container registry info...):

@inductor inductor added the bug Something isn't working label Jun 26, 2019
@tomoyamachi
Copy link
Collaborator

OK, I will check target file format when check ADD.

@tomoyamachi
Copy link
Collaborator

It may take a while. Please use -i CIS-DI-0009 flag so far.

tomoyamachi pushed a commit that referenced this issue Mar 8, 2020
@tomoyamachi
Copy link
Collaborator

It is possible to detect ADD with URL if using buildkit.

@olafurnielsen
Copy link

It is possible to detect ADD with URL if using buildkit.

Can you elaborate? I'm getting this fatal despite using buildkit. Are there any extra configuration needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants